Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurora - Deletion protection is at cluster level and not DB instance level - foundational security logic should be updated Closes #400 #401

Merged
merged 1 commit into from
May 31, 2022

Conversation

rajlearner17
Copy link
Contributor

Checklist

  • Issue(s) linked
select
  -- Required Columns
  arn as resource,
  case
    when engine like any ( ARRAY['aurora%', 'docdb', 'neptune']) then 'skip'
    when deletion_protection then 'ok'
    else 'alarm'
  end status,
  case
    when engine like any ( ARRAY['aurora%', 'docdb', 'neptune']) then title || ' is of ' || engine || ' cluster, deletion protection is set at cluster level.'
    when deletion_protection then title || ' deletion protection enabled.'
    else title || ' deletion protection not enabled.'
  end reason,
  -- Additional Dimensions
  region,
  account_id
from
  aws_rds_db_instance;
+-------------------------------------------------------------------+--------+-----------------------------------------------------------------------------------------------------+------------+--------------+
| resource                                                          | status | reason                                                                                              | region     | account_id   |
+-------------------------------------------------------------------+--------+-----------------------------------------------------------------------------------------------------+------------+--------------+
| arn:aws:rds:ap-south-1:123456768249:db:mysqldatabase-1            | alarm  | mysqldatabase-1 deletion protection not enabled.                                                    | ap-south-1 | 123456768249 |
| arn:aws:rds:ap-south-1:123456768249:db:auroracluster-1-instance-1 | skip   | auroracluster-1-instance-1 is of aurora-mysql cluster, deletion protection is set at cluster level. | ap-south-1 | 123456768249 |
| arn:aws:rds:us-east-1:123456768249:db:docdb-2022-05-30-10-11-42   | skip   | docdb-2022-05-30-10-11-42 is of docdb cluster, deletion protection is set at cluster level.         | us-east-1  | 123456768249 |
+-------------------------------------------------------------------+--------+-----------------------------------------------------------------------------------------------------+------------+--------------+

…level - foundational security logic should be updated Closes #400
@rajlearner17 rajlearner17 merged commit 8331bfc into release/v0.34 May 31, 2022
@rajlearner17 rajlearner17 deleted the fix-bug-fsbp-rds branch May 31, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants